Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass asset info in trade agg #15

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Pass asset info in trade agg #15

merged 3 commits into from
Jan 23, 2024

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Jan 23, 2024 •
edited
Loading

  • Pass asset_code, asset_issuer, and asset_type through trade agg instead of join with history_assets
  • trade_agg starts with yearly and left joins with other int_* tables in order to preserve all possible assets for trades
    Note: joins do not need the above columns. Joining on asset_id does effectively the same thing

sydneynotthecity
sydneynotthecity approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chowbao chowbao merged commit e3e67cb into master Jan 23, 2024
@sydneynotthecity sydneynotthecity deleted the pass-asset-info-in-trade-agg branch November 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneynotthecity sydneynotthecity sydneynotthecity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chowbao @sydneynotthecity